Skip to content

fix async sample mutex#44

Merged
richardstartin merged 2 commits into
mainfrom
rgs/fix-async-sample-mutex
Nov 15, 2023
Merged

fix async sample mutex#44
richardstartin merged 2 commits into
mainfrom
rgs/fix-async-sample-mutex

Conversation

@richardstartin
Copy link
Copy Markdown
Contributor

What does this PR do?:
Some regressions emerged after merging #43

  1. the thread local mutex behaviour is wrong when the the mutex isn't acquired successfully
  2. I just encountered a SIGSEGV in C [libjavaProfiler10944739960193922920.so+0x44848] Profiler::getJavaTraceAsyncRetryPopStub(void*, ASGCT_CallTrace*, int, CodeBlob*, StackFrame&)+0x40 locally

Motivation:

Additional Notes:

How to test the change?:

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@github-actions
Copy link
Copy Markdown
Contributor

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Warnings (2)

Style Violations (156)

@github-actions
Copy link
Copy Markdown
Contributor

🔧 Report generated by pr-comment-scanbuild

Scan-Build Report

User:runner@fv-az525-621
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 clean all
Clang Version:Ubuntu clang version 14.0.0-1ubuntu1.1
Date:Wed Nov 15 10:05:38 2023

Bug Summary

Bug TypeQuantityDisplay?
All Bugs6
Logic error
Assigned value is garbage or undefined1
Dereference of null pointer2
Result of operation is garbage or undefined1
Unused code
Dead initialization1
Dead nested assignment1

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Logic errorAssigned value is garbage or undefineddwarf.cppparseInstructions23120
Unused codeDead initializationlivenessTracker.cppcleanup_table451
Unused codeDead nested assignmentvmStructs.cppcheckNativeBinding7081
Logic errorDereference of null pointerflightRecorder.cppflush14008
Logic errorDereference of null pointersafeAccess.hload3518
Logic errorResult of operation is garbage or undefineddwarf.hgetSLeb12325

@richardstartin richardstartin marked this pull request as ready for review November 15, 2023 10:13
@richardstartin richardstartin merged commit c578955 into main Nov 15, 2023
@richardstartin richardstartin deleted the rgs/fix-async-sample-mutex branch January 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants